Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AXI4Memory): add support for WRAP burst mode, and fix a bug #3726

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eeeeewwz
Copy link

  1. Add support for WRAP burst mode.
  2. Fix a bug that when write data of two write transactions are asserted at two continuous cycles in W channel, and AW channel happens to be asserted at the second cycle, the second write transaction will be ignored

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: a011fba

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
a011fba 1.926 0.451 2.705 1.192 2.824 2.464 2.401 0.920 1.394 1.616 3.413 2.734 2.419 3.275

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
5d6c8ae 0.451 2.705 2.401 0.920 1.394 2.734 3.275
7a81e07 0.451 2.705 1.192 2.824 2.464 2.401 0.920 1.394 1.616 3.413 2.734 2.419 3.275
5e3e15d 1.926 0.451 2.705 1.192 2.824 2.464 2.401 0.920 1.394 1.616 3.413 2.734 2.419 3.275
75dea01 1.926 0.451 2.705 1.192 2.824 2.464 2.401 0.920 1.394 1.616 3.413 2.734 2.419 3.275
19870d3 1.926 0.451 2.705 1.192 2.824 2.464 2.401 0.920 1.394 1.616 3.413 2.734 2.419 3.275
b7a4433 1.926 0.451 2.705 1.192 2.824 2.464 2.401 0.920 1.394 1.616 3.413 2.734 2.419 3.275
753370f 1.926 0.451 2.705 1.192 2.824 2.464 2.401 0.920 1.394 1.616 3.413 2.734 2.419 3.275
ecac006 1.926 0.451 2.705 1.192 2.824 2.464 2.401 0.920 1.394 1.616 3.413 2.734 2.419 3.275
9acb8f9 1.926 0.451 2.705 1.192 2.824 2.464 2.401 0.920 1.394 1.616 3.413 2.734 2.419 3.275
d904dcf 1.926 0.451 2.705 1.192 2.824 2.464 2.401 0.920 1.394 1.616 3.413 2.734 2.419 3.275

@Tang-Haojin
Copy link
Member

Thank you for your contribution and sorry for the late reply.

Generally LGTM but could you rebase master again so that we can pass out newly added CI.

@eeeeewwz
Copy link
Author

eeeeewwz commented Nov 12, 2024

ok, I've done this

… when write data of two write transactions are asserted at two continuous cycles in W channel, and AW channel happens to be asserted at the second cycle, the second write transaction will be ignored
@Tang-Haojin Tang-Haojin self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants