fix MycroftAI/lingua-franca/issues/59 + 225 #11
Conversation
NeonJarbas
changed the title
NeonJarbas
changed the title
test/test_parse_en.py
Outdated
| # datetime(2017, 6, 10) -> saturday <- this is being extracted | ||
| # self.assertEqual( | ||
| # extract_datetime('i have things to do next weekend', dt)[0], | ||
| # extract_datetime('i have things to do next saturday', dt)[0]) |
There was a problem hiding this comment.
new bug detected, "next saturday" is not parsing well, possibly related to #16
|
I'm marking this for review sometime when I've got a whole hour for it, since there's so much to cross-reference. |
- handle last/past year/month/week
support for weekends
- handle X {time unit} earlier
- handle fractional decades/centuries/millenium
- handle decades/centuries/millenium ago
- add failing tests for extract last N {timeunit}
NeonJarbas
force-pushed
the
fix/mycroft#39
branch
from
46518a7 to
8563c26
Compare
Codecov Report
@@ Coverage Diff @@
## dev #11 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 58
Lines ? 14474
Branches ? 0
=====================================
Hits ? 0
Misses ? 14474
Partials ? 0 Continue to review full report at Codecov.
|
| datetime(2018, 1, 1, tzinfo=default_timezone())) | ||
|
|
||
| # old test moved here due to new disambiguation between "next week" and "in a week" | ||
| # testExtract("remind me to call mom next week", |
There was a problem hiding this comment.
Comment here is implemented below; consider removing comment?
There was a problem hiding this comment.
can be removed, is just documenting the difference in expected output, this test expects different things in mycroft and ovos
There was a problem hiding this comment.
I see, missed that the times are different
closes #14 , partially fixes #15
"in 1.5 centuries"notes on disambiguation:
TODO: