Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Proxy docs outdated, should point to fluentd instead #293

Open
Sheeri opened this issue Feb 28, 2024 · 8 comments
Open

Proxy docs outdated, should point to fluentd instead #293

Sheeri opened this issue Feb 28, 2024 · 8 comments

Comments

@Sheeri
Copy link
Contributor

Sheeri commented Feb 28, 2024

https://github.com/OpenLineage/docs/blob/main/docs/development/ol-proxy.md mentions the old proxy.

@dolfinus
Copy link
Contributor

dolfinus commented Apr 1, 2024

Do you mean something like this?

[INPUT]
    Name http
    Port 9200
    Mem_Buf_Limit 50MB
    successful_response_code 201
    success_header Content-Type application/json

[OUTPUT]
    Name http
    Match *
    host marquez-host
    port 5000
    uri /api/v1/lineage

https://docs.fluentbit.io/manual/pipeline/inputs/http
https://docs.fluentbit.io/manual/pipeline/outputs/http

@Sheeri
Copy link
Contributor Author

Sheeri commented Apr 1, 2024

No, I mean that https://github.com/OpenLineage/docs/blob/main/docs/development/ol-proxy.md contains instructions for how to build a proxy. At least some of this is outdated, for example:

Not only the OpenLineage proxy is useful in receiving the monitoring the OpenLineage events, it can also be used to relay the events to other endpoints. Please see the example of how to set the proxy to relay the events via Kafka topic or HTTP endpoint.

Relaying events to endpoints is generally accepted to be best done by fluentd. I'm not sure if a proxy is still favorable for receiving/monitoring OpenLineage events in general, but if so, then most of the page should be rewritten.

@dolfinus
Copy link
Contributor

dolfinus commented Apr 1, 2024

My question was about fluentd configuration which should be compatible with OpenLineage clients. In the previous comment I've added an example of config for fluent-bit, which is quite similar to fluentd.

@dolfinus
Copy link
Contributor

dolfinus commented Apr 3, 2024

Ah, I see, this is about this fluentd plugin:
https://github.com/OpenLineage/OpenLineage/tree/main/proxy/fluentd

I thought this is all about some generic fluentd input, like http or tcp.

@Sheeri
Copy link
Contributor Author

Sheeri commented Apr 3, 2024

Right! Because fluentd is preferred as a proxy, what purpose does this "ol-proxy" serve?

@dolfinus
Copy link
Contributor

dolfinus commented Apr 3, 2024

Whell, for now README of fluentd plugin says:

Fluentd support is experimental and could be changed or removed in a future release.

@Sheeri
Copy link
Contributor Author

Sheeri commented Apr 4, 2024 via email

@pawel-big-lebowski
Copy link
Collaborator

README content of Fluentd proxy should be moved to https://openlineage.io/docs which is https://github.com/OpenLineage/docs repo. Perhaps we can leave this issue not to forget this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants