Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] remove useless package json resolutions #2031

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guillaumejparis
Copy link
Member

@guillaumejparis guillaumejparis commented Dec 10, 2024

Proposed changes

Related issues

  • Closes #ISSUE-NUMBER

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Dec 10, 2024
@guillaumejparis
Copy link
Member Author

mini-css-extract-plugin is not used anywhere
react-transition-group is resolved at his last version (used by @mui/x-date-pickers)

@guillaumejparis guillaumejparis force-pushed the remove-useless-packagejson-resolutions branch from 2c5d931 to b294e57 Compare December 11, 2024 07:17
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.37%. Comparing base (36f02bf) to head (b294e57).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2031   +/-   ##
=========================================
  Coverage     33.37%   33.37%           
  Complexity     1668     1668           
=========================================
  Files           574      574           
  Lines         16798    16798           
  Branches        990      990           
=========================================
  Hits           5607     5607           
  Misses        10937    10937           
  Partials        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants