Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feedback]: Should list react-native-onesignal as a peer dependency or somehow express supported version range #236

Open
1 task done
conrad-vanl opened this issue Aug 20, 2024 · 1 comment

Comments

@conrad-vanl
Copy link

What's on your mind?

Trying to add this plugin on an existing app that uses a 4.x version of react-native-onesignal. I've been running into pod install issues, and just tracked it down to needing to be on a 1.x version of this plugin instead of a 2.x (we're not ready to upgrade react-native-onesignal to 5.x yet). This would've been much easier to track down if react-native-onesignal was listed as a peerDependency on this repo or otherwise communicated somewhere. The 2.0 release notes I don't think even make it entirely clear that the react-native-onesignal version number was being bumped to 5.x.

Otherwise, thanks for providing a great service!

Code of Conduct

  • I agree to follow this project's Code of Conduct
@spoeken
Copy link

spoeken commented Oct 28, 2024

This was so hard to figure out. yarn info onesignal-expo-plugin peerDependencies just gives undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants