Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Build fails on expo 49 with Xcode 15 #210

Open
1 task done
steveacalabro-indevets opened this issue Nov 14, 2023 · 1 comment
Open
1 task done

[Bug]: Build fails on expo 49 with Xcode 15 #210

steveacalabro-indevets opened this issue Nov 14, 2023 · 1 comment

Comments

@steveacalabro-indevets
Copy link

What happened?

When I try to build with latest versions of the repo using an expo app on expo 49 (support for xcode 15) I get the following error.


> 1 | #import <OneSignalFramework/OneSignalFramework.h>
    |         ^ 'OneSignalFramework/OneSignalFramework.h' file not found
  2 | 
  3 | #import "NotificationService.h"
  4 | ```

### Steps to reproduce?

```Markdown
1. Create an expo 49 application
2. Install the onesignal framework as described here [Expo SDK Setup](https://documentation.onesignal.com/docs/react-native-expo-sdk-setup)
3. Run expo prebuild `npx expo prebuild --clean`
4. Attempt to run iOS simulator using `npx expo run:ios`

What did you expect to happen?

I expect no errors to print and the SDK to work

OneSignal Expo SDK version

onesignal-expo-plugin: 2.0.2
react-native-onesignal:: 5.0.3

Platform

iOS

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@steveacalabro-indevets
Copy link
Author

Updating this as I found a workaround (for now)

In the app.json, if you include onesignal-expo-plugin first, it works. May be related to #154

"plugins": [
    [
        "onesignal-expo-plugin",
        {
            "mode": "development",
            "iPhoneDeploymentTarget": "13"
        }
    ],
    ...{rest of plugins}
 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant