Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to work with react-native-onesignal@5 #193

Closed
danbovey opened this issue Aug 23, 2023 · 2 comments · Fixed by #195
Closed

Update to work with react-native-onesignal@5 #193

danbovey opened this issue Aug 23, 2023 · 2 comments · Fixed by #195

Comments

@danbovey
Copy link

I installed react-native-onesignal and onesignal-expo-plugin at latest versions and they're incompatible because the expo plugin is pointing at lower versions of the native module. Haven't tried an Android build but that might need updating too.

onesignal-expo-plugin/support/iosConstants.ts

Line 6 in 495beb5

pod 'OneSignalXCFramework', '>= 3.0', '< 4.0'

@yernandus
Copy link

facing the same issue. I had to manually update my pod file which is a hack

@nan-li nan-li mentioned this issue Aug 28, 2023
Closed
1 task
@rgomezp rgomezp mentioned this issue Aug 28, 2023
Merged
8 tasks
@aindong
Copy link

aindong commented Sep 7, 2023

this issue is solved with #195 please help to merge that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Native version update & major release OneSignal/onesignal-expo-plugin
3 participants
@danbovey @aindong @yernandus