From f7c8c3139fa01123e7925a698fbc971b432c8410 Mon Sep 17 00:00:00 2001 From: Rodrigo Gomez Palacio Date: Mon, 28 Aug 2023 12:35:33 -0500 Subject: [PATCH 1/4] Update native iOS version range --- support/iosConstants.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/iosConstants.ts b/support/iosConstants.ts index cf988aa..2541bae 100644 --- a/support/iosConstants.ts +++ b/support/iosConstants.ts @@ -3,7 +3,7 @@ export const TARGETED_DEVICE_FAMILY = `"1,2"`; export const NSE_PODFILE_SNIPPET = ` target 'OneSignalNotificationServiceExtension' do - pod 'OneSignalXCFramework', '>= 3.0', '< 4.0' + pod 'OneSignalXCFramework', '>= 5.0', '< 6.0' use_frameworks! :linkage => podfile_properties['ios.useFrameworks'].to_sym if podfile_properties['ios.useFrameworks'] end`; From 3895e22f82362d51fd98b228281a0f0c12e4862e Mon Sep 17 00:00:00 2001 From: Rodrigo Gomez Palacio Date: Mon, 28 Aug 2023 12:35:51 -0500 Subject: [PATCH 2/4] Nits --- onesignal/withOneSignalAndroid.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/onesignal/withOneSignalAndroid.ts b/onesignal/withOneSignalAndroid.ts index bbf8e27..08fe584 100644 --- a/onesignal/withOneSignalAndroid.ts +++ b/onesignal/withOneSignalAndroid.ts @@ -1,5 +1,5 @@ /** - * Expo config plugin for One Signal (Android) + * Expo config plugin for OneSignal (Android) * @see https://documentation.onesignal.com/docs/react-native-sdk-setup#step-4-install-for-ios-using-cocoapods-for-ios-apps */ @@ -13,8 +13,8 @@ import { existsSync, mkdirSync, writeFileSync } from 'fs'; const RESOURCE_ROOT_PATH = 'android/app/src/main/res/'; // The name of each small icon folder resource, and the icon size for that folder. -const SMALL_ICON_DIRS_TO_SIZE: { [name: string]: number } = { - 'drawable-mdpi': 24, +const SMALL_ICON_DIRS_TO_SIZE: { [name: string]: number } = { + 'drawable-mdpi': 24, 'drawable-hdpi': 36, 'drawable-xhdpi': 48, 'drawable-xxhdpi': 72, @@ -22,7 +22,7 @@ const SMALL_ICON_DIRS_TO_SIZE: { [name: string]: number } = { }; // The name of each large icon folder resource, and the icon size for that folder. -const LARGE_ICON_DIRS_TO_SIZE: { [name: string]: number } = { +const LARGE_ICON_DIRS_TO_SIZE: { [name: string]: number } = { 'drawable-xxxhdpi': 256 }; From 367eefb4e8c10764170c94e4f0eeb816ec2f7ae6 Mon Sep 17 00:00:00 2001 From: Rodrigo Gomez Palacio Date: Mon, 28 Aug 2023 12:40:24 -0500 Subject: [PATCH 3/4] Major release commit --- package.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index bf6b4e1..1e2999b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "onesignal-expo-plugin", - "version": "1.3.2", + "version": "2.0.0", "description": "The OneSignal Expo plugin allows you to use OneSignal without leaving the managed workflow. Developed in collaboration with SweetGreen.", "main": "./app.plugin.js", "scripts": { @@ -25,7 +25,8 @@ "Karen Grigoryan", "Rodrigo Gomez-Palacio", "Charlie Cruzan", - "Wojciech Kozyra" + "Wojciech Kozyra", + "Brian Smith" ], "license": "MIT", "bugs": { From 71024964c5769972bb8ebde550800c27009df4fd Mon Sep 17 00:00:00 2001 From: Rodrigo Gomez Palacio Date: Mon, 11 Sep 2023 14:04:17 -0500 Subject: [PATCH 4/4] Update NotificationService.m file Change based on migration guide instructions: https://github.com/OneSignal/OneSignal-iOS-SDK/blob/major_release_5.0.0/MIGRATION_GUIDE.md#sdk-installation --- support/serviceExtensionFiles/NotificationService.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/serviceExtensionFiles/NotificationService.m b/support/serviceExtensionFiles/NotificationService.m index a24a15d..dc5de87 100644 --- a/support/serviceExtensionFiles/NotificationService.m +++ b/support/serviceExtensionFiles/NotificationService.m @@ -1,4 +1,4 @@ -#import +#import #import "NotificationService.h"