Fix Widget Kit Refreshing Bug #778
Merged
+60
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbrethorst
requested changes
Dec 10, 2024
There was a problem hiding this comment.
looks good! There's one change I'd like to see about how a new apiService object is constructed, but otherwise 🚀 .
Also, I'm not sure why the CI is failing. Tests are passing, so 🤷 . I'll get this merged once your change is in and we can worry about CI later.
| @@ -129,6 +129,15 @@ open class CoreApplication: NSObject, | |||
| self.apiService = RESTAPIService(APIServiceConfiguration(baseURL: region.OBABaseURL, apiKey: config.apiKey, uuid: userUUID, appVersion: config.appVersion, regionIdentifier: region.regionIdentifier)) | |||
| } | |||
|
|
|||
| public func getNewRefreshedRESTAPIService() -> RESTAPIService? { | |||
| func loadData() async { | ||
| arrDepDic = [:] | ||
|
|
||
| guard let apiService = app.getNewRefreshedRESTAPIService() else { |
There was a problem hiding this comment.
call app.refreshServices() and then use app.apiService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
The problem was that RestAPIServices wasn’t refreshing properly when changing to new region due to some reasons. I added a method, getRefreshedAPIService, to fix this issue efficiently FOR NOW :)
Preview:
e036f0c1d9b84114bce4c299642b8c0c.MP4