-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS 18 compatible OBA Widget Extension #753
Conversation
@aaronbrethorst - can you please review it. |
Hey @aaronbrethorst, if you need any help, just let me know. I'd be happy to volunteer!. |
@manu-r12 sorry I didn’t have a chance to review today! It’s at the top of my todo list for tomorrow. Unexpectedly lost childcare all this week so finding time for … well, everything has been a challenge. |
Hey @aaronbrethorst , no worries at all, life happens, and I totally understand. Please take your time ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good! I have noted a couple questions and some minor changes. Once you have those sorted out, I'll do a final UI review and we'll get this merged!
- fixed date formatting
Hey @manu-r12 - apologies for not responding sooner. I was having trouble getting the widget to show up in my simulator and thought I was doing something wrong, but after spending an hour reading, troubleshooting, and trying to figure this out, I think something else is going on. Can you give me a detailed set of steps to get the widget to show up? |
@manu-r12 I see the problem: creating a new project from scratch that includes a widget shows:
Both of these settings are controlled by adding the Widget target to the list of App's dependencies in Can you make this change in your branch? Thanks again for your patience! It's been a rather ridiculous month (happy to tell you about it on Slack) |
Thanks for the clarification Arron 😊 |
@manu-r12 ok, now we're in business! this is looking good. I need to spend a bit more time testing it on device and then I'll get it merged. thank you for spearheading this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks for your contribution! I can't wait to get it into the App Store :)
Looking forward to feedback and excited to see this live 🚀 |
Description:
Media:
Preview -