Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 18 compatible OBA Widget Extension #753

Merged
merged 13 commits into from
Nov 27, 2024

Conversation

manu-r12
Copy link
Contributor

Description:

  • Added a WidgetKit widget to display transit arrivals and departures at a glance.
  • Optimized for iOS 18 compatibility.
  • The widget refreshes every 30 minutes or can be refreshed through user interaction.

Media:

Preview -

Screenshot 2024-10-23 at 3 19 37 PM

@manu-r12
Copy link
Contributor Author

@aaronbrethorst - can you please review it.

@manu-r12
Copy link
Contributor Author

Hey @aaronbrethorst, if you need any help, just let me know. I'd be happy to volunteer!.

@aaronbrethorst
Copy link
Member

@manu-r12 sorry I didn’t have a chance to review today! It’s at the top of my todo list for tomorrow. Unexpectedly lost childcare all this week so finding time for … well, everything has been a challenge.

@manu-r12
Copy link
Contributor Author

Hey @aaronbrethorst , no worries at all, life happens, and I totally understand. Please take your time ❤️

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good! I have noted a couple questions and some minor changes. Once you have those sorted out, I'll do a final UI review and we'll get this merged!

OBAWidget/Components /RefreshButton.swift Outdated Show resolved Hide resolved
OBAWidget/Components /RefreshButton.swift Outdated Show resolved Hide resolved
OBAWidget/Entries/BookmarkEntry.swift Outdated Show resolved Hide resolved
@aaronbrethorst
Copy link
Member

Hey @manu-r12 - apologies for not responding sooner. I was having trouble getting the widget to show up in my simulator and thought I was doing something wrong, but after spending an hour reading, troubleshooting, and trying to figure this out, I think something else is going on. Can you give me a detailed set of steps to get the widget to show up?

image

@manu-r12 manu-r12 closed this Nov 25, 2024
@manu-r12 manu-r12 reopened this Nov 25, 2024
@manu-r12
Copy link
Contributor Author

Try searching for the application name; it should appear in the list.
if searching for the application name doesn't work, could you please provide the steps you're following?

Screenshot 2024-11-25 at 9 13 31 AM

@aaronbrethorst
Copy link
Member

@manu-r12 I see the problem: creating a new project from scratch that includes a widget shows:

  1. the widget is set as a Target Dependency of the app
  2. the widget is embedded into the app

Both of these settings are controlled by adding the Widget target to the list of App's dependencies in Apps/Shared/app_shared.yml

image

Can you make this change in your branch? Thanks again for your patience! It's been a rather ridiculous month (happy to tell you about it on Slack)

image

@manu-r12
Copy link
Contributor Author

manu-r12 commented Nov 26, 2024

Thanks for the clarification Arron 😊

@aaronbrethorst
Copy link
Member

@manu-r12 ok, now we're in business! this is looking good. I need to spend a bit more time testing it on device and then I'll get it merged. thank you for spearheading this!

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for your contribution! I can't wait to get it into the App Store :)

@aaronbrethorst aaronbrethorst merged commit 6cdb5cb into OneBusAway:main Nov 27, 2024
1 of 2 checks passed
@manu-r12
Copy link
Contributor Author

Looking forward to feedback and excited to see this live 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants