-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrated search(route) and search(stop) pages to REST API Method #127
base: main
Are you sure you want to change the base?
Conversation
sir @aaronbrethorst ,
|
Everything done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! looks like good progress. I've noted some changes to make below.
src/_data/rest_api.json
Outdated
@@ -102,6 +102,12 @@ | |||
|
|||
"vehicles-for-agency": { | |||
"description": "get active vehicles for an agency" | |||
}, | |||
"search (stop)": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please alphabetize these two methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please rename the new pages to search-stop
and search-route
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sir, i need 2 little bit clarifications
- either we can keep
search-route
orSearch-Route
for the new page name and method name, because the both should be same else it will show 404 - we can change
page title
which can be differ from thepage name
can we keepsearch-route
format everywhere?
ok sir! |
this is marked as a draft. is it ready for review again? |
i've marked this not ready for the review because if i push it'll create a new commit and i was unable to squash it. |
if you have changes to push, please push them |
ok sir, pushed the changes,please verify!sorry again tried but unable to squash, i tried following
|
Description:
migration of the two pages and jsoneditor support added for the check please refer to
Issued fixed
sectionIMP NOTE
i've added the links at the end of instead of the ascending order because these page/methods were little bit different form others
Issue fixed:
because of above issues I tried to fix all of them by migrating the both pages
Changes done:
Screenshots/Videos
✅️ By submitting this PR, I have verified the following