-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed : SideBar Functionality #108
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the sidebar appearing on any pages anymore. Also I'm not clear on what this PR is supposed to be fixing.
The purpose of this PR is to provide color change in the right sidebar section. Currently, when a user clicks on the right sidebar menu, there is no response shown in the sidebar section. Now, it changes its color to give the user feedback on their current position. Additionally, I removed the sidebar from where only heading is present. |
This PR needs to be rebased against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like where you're going with this, but I don't think it makes sense to highlight the <h2>
references in the sidebar on clicking them unless they also get highlighted just by scrolling down the page. Check out intersection observers for an idea of how to do this: https://alpinejs.dev/plugins/intersect
Okay, sir, I will try to achieve this. |
Yeah, but as a separate commit please. |
Okay ,sir. |
Description:
Fixed : #107
Issue fixed:
Currently, there's no visual indication to signify which item in the sidebar the user has selected, making navigation less intuitive.
The sidebar remains visible even on pages where no content is available, leading to an unnecessary distraction and potential confusion for users.
Changes done:
Screenshots/Videos
Before :
After :
✅️ By submitting this PR, I have verified the following