Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed : SideBar Functionality #108

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Devmoni
Copy link
Contributor

@Devmoni Devmoni commented Mar 24, 2024

Description:

Fixed : #107

Issue fixed:

  1. Currently, there's no visual indication to signify which item in the sidebar the user has selected, making navigation less intuitive.

  2. The sidebar remains visible even on pages where no content is available, leading to an unnecessary distraction and potential confusion for users.

Changes done:

  • Task 1

Screenshots/Videos

Before :

1

2

After :

3

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Tried squashing the commits into one

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the sidebar appearing on any pages anymore. Also I'm not clear on what this PR is supposed to be fixing.

@Devmoni
Copy link
Contributor Author

Devmoni commented Apr 12, 2024

The purpose of this PR is to provide color change in the right sidebar section. Currently, when a user clicks on the right sidebar menu, there is no response shown in the sidebar section. Now, it changes its color to give the user feedback on their current position. Additionally, I removed the sidebar from where only heading is present.

@aaronbrethorst
Copy link
Member

This PR needs to be rebased against main

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where you're going with this, but I don't think it makes sense to highlight the <h2> references in the sidebar on clicking them unless they also get highlighted just by scrolling down the page. Check out intersection observers for an idea of how to do this: https://alpinejs.dev/plugins/intersect

@Devmoni
Copy link
Contributor Author

Devmoni commented Apr 15, 2024

Okay, sir, I will try to achieve this.
Regarding the suggested change, should I include it in the same pull request?

@aaronbrethorst
Copy link
Member

Yeah, but as a separate commit please.

@Devmoni
Copy link
Contributor Author

Devmoni commented Apr 15, 2024

Okay ,sir.

@Devmoni Devmoni requested a review from aaronbrethorst April 18, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancements for Sidebar Functionality
2 participants