Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom code away classname clashes and auth error #90

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

ms-jpq
Copy link
Contributor

@ms-jpq ms-jpq commented Nov 30, 2024

hihi! 👋:

PR to fix away two issues with current kotlin SDK that prevents compilation / CI release.

  • Class name List clashes with kotlin's builtin collections' List -> fixed via adding qualifications to kotlin built-in List

  • The API Key should go in query param not headers :)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ms-jpq ms-jpq changed the title fix: custom code away classname clashes fix: custom code away classname clashes and auth error Nov 30, 2024
@Ahmedhossamdev Ahmedhossamdev merged commit 53bc0fc into OneBusAway:next Nov 30, 2024
2 of 3 checks passed
@Ahmedhossamdev
Copy link
Member

Hi @ms-jpq

I appreciate you taking the time and effort to fix this.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants