Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Don't use -1 to mean "forever" in lockoutpolicy and passwordpolicy tests #189

Closed
chisholm opened this issue Mar 18, 2014 · 0 comments
Closed
Milestone

Comments

@chisholm
Copy link
Contributor

The relevant API uses DWORDs to represent many account policy related configuration options. The real system values should be used in items, not -1, which is an illegal value for a DWORD. See NetUserModalsGet().

We think -1 was originally used because the macro "TIMEQ_FOREVER" is defined in a system header as "((unsigned long) -1L)". -1 occurs as an implementation detail of the macro definition. Tests should not be defined in terms of these sorts of implementation details.

@mhansbury mhansbury assigned LuisNunez and djhaynes and unassigned LuisNunez and djhaynes May 8, 2014
@drothenberg drothenberg added this to the 5.11.1 milestone Apr 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants