Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not early return when no relevant code owner exists #40

Merged
merged 3 commits into from
Apr 28, 2024

Conversation

saschanaz
Copy link
Contributor

Fixes #39

I'd like to have a test but this doesn't really fit into the existing unit tests.

@saschanaz
Copy link
Contributor Author

saschanaz commented Jun 20, 2023

The tests pass locally, what does it mean by unexpected token? How can it happen? 🤔

@orta
Copy link
Collaborator

orta commented Jun 21, 2023

Hah, no idea about that jest error - maybe a weird npx issue?

I think I'd prefer if the label code just moves up above the return instead, mainly so that it's still really obvious that it's not going to accidentally do any work in the fn if no users are found

@saschanaz
Copy link
Contributor Author

saschanaz commented Jun 21, 2023

I think I'd prefer if the label code just moves up above the return instead, mainly so that it's still really obvious that it's not going to accidentally do any work in the fn if no users are found

Isn't it obvious as the code still returns inside if (!ownersWhoHaveAccessToAllFilesInPR.length)?

@orta
Copy link
Collaborator

orta commented Apr 28, 2024

👍🏻

@orta orta merged commit 7c66472 into OSS-Docs-Tools:master Apr 28, 2024
1 check passed
@saschanaz saschanaz deleted the patch-1 branch April 28, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The maintainer assignation doesn't happen if there's no relevant code owner at all
2 participants