feat: check teams #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoovon
commented
Sep 25, 2022
| @@ -15,7 +15,7 @@ packages/documentation/copy/ja/**/*.ts @sasurau4 @Quramy @Naturalclar @Takepepe | |||
| # Collaborators for Portuguese Translation of the Website | |||
| packages/playground-examples/copy/pt/**/*.md @khaosdoctor @danilofuchs @orta | |||
| packages/playground-examples/copy/pt/**/*.ts @khaosdoctor @danilofuchs @orta | |||
| packages/tsconfig-reference/copy/pt/**/*.md @khaosdoctor @danilofuchs @orta | |||
| packages/tsconfig-reference/copy/pt/**/*.md @khaosdoctor @danilofuchs @orta @teamA | |||
There was a problem hiding this comment.
@orta in order to test this properly I think I need either of the following please:
- membership of OSS-Docs-Tools/teamA (can be temporary if you like); or
- details of a substitute team within the organisation (such team not containing
khaosdoctordanilofuchsnororta)
There was a problem hiding this comment.
@orta is this something which can be done? Keen to merge this in if possible.
There was a problem hiding this comment.
The tests need to mock the github API calls and be moved to use real async code, as this PR doesn't look like it would work to me
That said - @TeamA has the account @dangermcshane set up - so we can verify post-merge, https://github.com/orgs/OSS-Docs-Tools/teams/teama
stoovon
force-pushed
the
check-team-membership
branch
from
ada9a11 to
3f4fc4e
Compare
Check team membership. Fixes OSS-Docs-Tools#13
stoovon
force-pushed
the
check-team-membership
branch
from
3f4fc4e to
c2a0f77
Compare
AirOne70
added a commit
to KUBA-ENG-Platform/code-owner-self-merge
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check team membership.
Fixes #13