Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action doesn't work for organization teams #13

Open
erickzhao opened this issue Oct 30, 2020 · 2 comments
Open

Action doesn't work for organization teams #13

erickzhao opened this issue Oct 30, 2020 · 2 comments

Comments

@erickzhao
Copy link

Hey there, this is a super useful plugin! However, it doesn't seem to work with the @org/team-name syntax as specified in the CODEOWNERS spec.

It seems like the codeowners npm package only returns the raw team name rather than its members, so a member of the team saying LGTM unfortunately does nothing here (example).

I'm not sure how feasible this is, but there is a List Team Members API in octokit that exists.

@orta
Copy link
Collaborator

orta commented Oct 30, 2020

Yeah - given that any username with a slash must be a team member, I think it's totally reasonable to add code which uses the API to determine if they have the right to merge 👍🏻

You're welcome to give it a shot

@orta
Copy link
Collaborator

orta commented Oct 30, 2020

Looking at your example, the bot couldn't ping the team either - so maybe there's a general constraint on how that works too

stoovon added a commit to stoovon/code-owner-self-merge that referenced this issue Sep 25, 2022
Check team membership.

Fixes OSS-Docs-Tools#13
stoovon added a commit to stoovon/code-owner-self-merge that referenced this issue Sep 25, 2022
Check team membership.

Fixes OSS-Docs-Tools#13
stoovon added a commit to stoovon/code-owner-self-merge that referenced this issue Sep 25, 2022
Check team membership.

Fixes OSS-Docs-Tools#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants