Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 3.9 - The react error boundary UI immediately closes when you click Show Details, and the error is no longer logged to console. #4537

Closed
JamesAPetts opened this issue Nov 20, 2024 · 4 comments
Assignees
Labels
Bug Verified Bug reported, reproducible, and verified.

Comments

@JamesAPetts
Copy link
Member

Describe the Bug

If you have an uncaught error somewhere, this is now caught and displayed to the user:

Screenshot 2024-11-20 at 16 26 03

Two main issues:

  • Clicking on the Show Details opens the dialog for a single frame and its closed again.
  • Its very annoying that this error is no longer actually logged, so you can't click through the stack trace, so we should also console.error() it.

Steps to Reproduce

Generate any error which would be hit by react.

The current behavior

Show Details doesn't work correctly, and no error is logged.

The expected behavior

Show Details works correctly, and an error is logged.

OS

N/A

Node version

N/A

Browser

N/A

@JamesAPetts JamesAPetts added the Awaiting Reproduction Can we reproduce the reported bug? label Nov 20, 2024
@salimkanoun
Copy link
Contributor

+1

@sedghi sedghi added the Bug Verified Bug reported, reproducible, and verified. label Nov 21, 2024 — with Linear
@sedghi sedghi removed the Awaiting Reproduction Can we reproduce the reported bug? label Nov 21, 2024
@IbrahimCSAE
Copy link
Collaborator

IbrahimCSAE commented Nov 22, 2024

can u guys please clarify what the issue is? I can't replicate these two points

  • Clicking on the Show Details opens the dialog for a single frame and its closed again.
  • Its very annoying that this error is no longer actually logged, so you can't click through the stack trace, so we should also console.error() it.

I can do all of this in the video below

https://share.cleanshot.com/PkZpVj7p

@IbrahimCSAE
Copy link
Collaborator

another example:

https://share.cleanshot.com/3HFLrLll

@IbrahimCSAE
Copy link
Collaborator

Linear auto closed this, let me know if you have re-producable steps

@sedghi sedghi closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Verified Bug reported, reproducible, and verified.
Projects
None yet
Development

No branches or pull requests

4 participants