[18.0][MIG] sale_procurement_group_by_line: Migration to 18.0.

[MeritxellAForgeFlow]

Migration to 18.0

@ForgeFlow

[OCA-git-bot]

Sorry @RicardCForgeFlow you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[JordiMForgeFlow]

Could you include the module name in the MIG commit like: [MIG] sale_procurement_group_by_line: Migration to V18?

Code review LGTM :)

[RicardCForgeFlow]

Code review 👍

[AaronHForgeFlow]

Code review LGTM

[MiquelRForgeFlow]

Suggested change

	if line.state != "sale" or line.product_id.type not in ("consu", "product"):
	if line.state != "sale" or line.order_id.locked or line.product_id.type != 'consu':

[MiquelRForgeFlow]

Suggested change

	product_qty, procurement_uom = line_uom._adjust_uom_quantities(
	product_qty, quant_uom
	)
	procurements.append(
	self.env["procurement.group"].Procurement(
	line.product_id,
	product_qty,
	procurement_uom,
	line.order_id.partner_shipping_id.property_stock_customer,
	line.display_name,
	line.order_id.name,
	line.order_id.company_id,
	values,
	)
	)
	origin = f'{line.order_id.name} - {line.order_id.client_order_ref}' if line.order_id.client_order_ref else line.order_id.name
	product_qty, procurement_uom = line_uom._adjust_uom_quantities(
	product_qty, quant_uom
	)
	procurements += line._create_procurements(product_qty, procurement_uom, origin, values)

[MiquelRForgeFlow]

Suggested change

	self.assertEqual(self.line1.move_ids.name, self.line1.display_name)
	self.assertEqual(len(self.line2.move_ids), 1)
	self.assertEqual(self.line2.move_ids.name, self.line2.display_name)
	self.assertEqual(self.line1.move_ids.name, self.line1.product_id.display_name)
	self.assertEqual(len(self.line2.move_ids), 1)
	self.assertEqual(self.line2.move_ids.name, self.line2.product_id.display_name)

or something like this.

It seems it's due to odoo/odoo@4cc2b3b

[MiquelRForgeFlow]

Added v17 changes in a separated commit (a forward port of #3428).

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖