[17.0][ADD] repair_part_source_location #67
Conversation
imlopes
force-pushed
the
17.0-add-repair_part_source_location
branch
from
90697bf to
3fe6650
Compare
| @api.onchange("picking_type_id") | ||
| def _onchange_picking_type_id(self): | ||
| if self.picking_type_id: | ||
| self.parts_source_location_id = self.picking_type_id.default_location_src_id |
There was a problem hiding this comment.
Onchanges are being replaced by computed methods, whenever possible.
Could you change it to a computed field, just like the other fields in this model. E.g.:
|
|
||
|
|
||
| class StockMove(models.Model): | ||
| _inherit = "stock.move" |
There was a problem hiding this comment.
If this ends up being empty like this, better to just remove it
| class StockMove(models.Model): | |
| _inherit = "stock.move" |
| MAP_REPAIR_LINE_TYPE_TO_MOVE_LOCATIONS_FROM_REPAIR, | ||
| ) | ||
|
|
||
| MAP_REPAIR_LINE_TYPE_TO_MOVE_LOCATIONS_FROM_REPAIR["add"] = { |
There was a problem hiding this comment.
I have weird feelings about patching this.
It seems this variable is only used in the stock.move._get_repair_locations method, and that seems easy to override.
I think it'd be much cleaner to do that instead
|
This PR has the |
|
It may be conflicting with @imlopes can you check? |
|
I agreed with you @ivantodorovich |
No description provided.