Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] partner_bank_acc_type_constraint #1904

Open
wants to merge 13 commits into
base: 18.0
Choose a base branch
from

Conversation

alexis-via
Copy link
Contributor

No description provided.

@alexis-via
Copy link
Contributor Author

/ocabot migrate partner_bank_acc_type_constraint

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via. Your command failed:

Invalid command: migrate.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@rousseldenis
Copy link
Contributor

/ocabot migration partner_bank_acc_type_constraint

acc_types = self.env["res.partner.bank"].get_supported_account_types()
if any([x[0] == "iban" for x in acc_types]):
# create valid IBAN
pbank2 = self.env["res.partner.bank"].create(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexis-via It seems this line is not accessed in test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, using odoo_test_helper and adding "iban" in selection if not exists during setupClass will ensure the functionality is tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants