Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "phenotype" to COB #225

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add "phenotype" to COB #225

wants to merge 1 commit into from

Conversation

matentzn
Copy link
Contributor

fixes #123

Let the war begin.

fixes #123 

Let the ware begin.
@wdduncan
Copy link
Member

Yes ... I imagine there will be a lot of back forth about this.

@matentzn Are you proposing that by making phenotype a top level class that a particular phenotype may be a characteristic, material entity, or process? This suggests to me that it would be better to define a phenotype of object property (which I mentioned here); e.g.:

  • facial tics phenotype of Tourette syndrome
  • tumor phenotype of cancer
  • discoloration phenotype of rash

@addiehl
Copy link

addiehl commented Jan 26, 2023

I'm not against the object property approach but I think the inverses should be used here (in a weakened form in some cases):
Tourette syndrome sometimes associated with phenotype facial tics
cancer associated with phenotype tumor (although perhaps cancer disease has basis in tumor might be better although this is a bit chicken and egg)
rash sometimes associated with phenotype discoloration

@matentzn
Copy link
Contributor Author


<owl:Class rdf:about="http://purl.obolibrary.org/obo/COB_0001001">
<obo:IAO_0000115>The set of observable characteristics of an individual resulting from the interaction of its genotype with the environment.</obo:IAO_0000115>
<rdfs:label xml:lang="en">phenotype</rdfs:label>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an alternative would be to avoid the shared "phenotype" term, and use phenotypic effect instead, as @dosumis has been suggesting.

@wdduncan
Copy link
Member

wdduncan commented Jan 26, 2023

@matentzn In UPHENO, phenotype is a type of quality.

image

Shouldn't it be the same in COB?

@matentzn
Copy link
Contributor Author

Yes, this is really controversial, and should probably not be in Upheno..

@matentzn matentzn marked this pull request as draft February 19, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Where to place phenotype?
3 participants