Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Book Proofread #259

Open
julio4 opened this issue Nov 21, 2024 · 9 comments · May be fixed by #263
Open

Feat: Book Proofread #259

julio4 opened this issue Nov 21, 2024 · 9 comments · May be fixed by #263
Assignees
Labels

Comments

@julio4
Copy link
Contributor

julio4 commented Nov 21, 2024

Description

In this issue, we need thorough proofreading of the Starknet By Example book to identify significant issues that could affect developer understanding. The goal is to maintain a high-quality, accurate documentation that reflects current best practices and correct implementation details.

What to Look For

  • Logic inaccuracies or outdated information
  • Mismatched explanations
  • Deprecated/outdated features or syntax
  • Inconsistencies between different sections
  • Missing critical information or incomplete explanations
  • Logic errors in explanations or implementations

Review Process and Criterias

  1. Read through the documentation with care
  2. Document any significant issue found, including:
    • The specific location (URL/section/line number)
    • Current content/context
    • Why it's problematic
    • Suggested correction or improvement
  3. If the issue require substantial changes you can also open a separate issue (with a link to this issue)
  4. Group any related issues if they have the same root cause

ODHack

To be eligible for additional rewards, be sure to review and follow the ODHack Common Guidelines and Contributing Guidelines.

Be sure to join the telegram group and introduce yourself.

@od-hunter
Copy link

od-hunter commented Nov 21, 2024

Hi @julio4 , can I work on this please? I'm also good at documentations. Below are some of the documentations I've done that were merged:
dojoengine/book#308,
keep-starknet-strange/joyboy#143,
Scaffold-Stark/ss2-docs#31,
horuslabsio/Starknet-Scaffold#94,
Hyle-org/examples#15.
For this issue, after cloning the repository, I'll focus on Logic Errors (Incorrect or outdated code examples),
Consistency (Mismatched terminology or formatting across sections), Completeness (Missing explanations or incomplete implementation steps), Deprecation (References to outdated or unsupported features).
Then, I'll describe the logic or content problem.
I'll provide corrected explanations or updated code.
I'll test examples locally using CLI tools, then document errors or deviations in outputs. I'll use markdownlint to check syntax and format. KIndly assign me please.

ETA: 54 hours.

@akintewe
Copy link

Hi, I'm akintewe and i would love to work on this issue
I My ETA is > 24hrs to complete.

I have experience in Cairo, javascript and also alittle solidity, which would help me with this issue. I would make sure i document any issues found, make sure everything is precise and accurate.

I am very good with documentation too.

I am a new contributor, happy to help :)

@NueloSE
Copy link
Contributor

NueloSE commented Nov 21, 2024

Can I work on this, please?

@vestor-dev
Copy link

Is it okay if I take this?
please kindly assign

@Supa-mega
Copy link

May I take this issue on?

@ShantelPeters
Copy link

Can I try solving this issue?

@sandragcarrillo
Copy link

Hi, I would love to contribute to this issue. As I have been learning Cairo for the past 3 months, I have been using Starknet by example and finding some issues such as deprecated features and missing explanations. I would love to take that experience and make it a contribution solving this issue.

@julio4
Copy link
Contributor Author

julio4 commented Nov 22, 2024

Assigned mainly @od-hunter BUT everyone can still contribute directly here without having to be assigned. For any finding I'll create a separate issue and assign someone to it.

@od-hunter
Copy link

Assigned mainly @od-hunter BUT everyone can still contribute directly here without having to be assigned. For any finding I'll create a separate issue and assign someone to it.

Will get to it🫡

@od-hunter od-hunter linked a pull request Nov 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants