Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SRC5 Interface detection #109

Open
julio4 opened this issue Nov 10, 2023 · 8 comments · May be fixed by #272
Open

feat: SRC5 Interface detection #109

julio4 opened this issue Nov 10, 2023 · 8 comments · May be fixed by #272
Assignees
Labels
good first issue Good for newcomers

Comments

@julio4
Copy link
Contributor

julio4 commented Nov 10, 2023

Reference: https://github.com/starknet-io/SNIPs/blob/main/SNIPS/snip-5.md

@julio4 julio4 added the good first issue Good for newcomers label Nov 26, 2023
@mubarak23
Copy link

@julio4 can you give more context to this

@julio4
Copy link
Contributor Author

julio4 commented Apr 7, 2024

@julio4 can you give more context to this

Show an example of how a contract can implement the ISRC5 trait to comply with SRC-5 for interfaces detection.

@mubarak23
Copy link

from the above docs shared, we are implementing a trait function that check this interface_id == 0x3f918d17e5ee77373b56385708f855659a07f75997f365cf87748628532a055

@julio4
Copy link
Contributor Author

julio4 commented Apr 7, 2024

from the above docs shared, we are implementing a trait function that check this interface_id == 0x3f918d17e5ee77373b56385708f855659a07f75997f365cf87748628532a055

Not exactly, this specific interface_id is only an example. SRC5 is a standard that define how to generate interface ids and how a contract can publish what interfaces it implements in order to allow anyone to query if the contract implement it.
You can take a look at the OZ implementation for an example here

@mubarak23
Copy link

this OpenZeppelin implementation is somewhat same thing we are going to do here

@julio4
Copy link
Contributor Author

julio4 commented Apr 7, 2024

this OpenZeppelin implementation is somewhat same thing we are going to do here

Yes but not as a component (atleast for now), we only want to demonstrate how one contract can implement the trait to return true for a specific interface id. So developers can quickly understand without having to read all the SNIP!

@mubarak23
Copy link

Alright @julio4 kindly assign this to me, i will work on it

@Jemiiah
Copy link
Contributor

Jemiiah commented Jun 26, 2024

i would love to work on this issue @julio4

This was referenced Nov 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants