weep incorrectly detects a shell

[igr]

There is no -g option for the set command in Bash 5.1 on mac:

This is what worked for me when executing from the bash script:

cmd=$(weep export arn:aws:iam::123:/aaa/sss)
cmd=${cmd//"set -gx"/"export"}
cmd=${cmd//" \""/=\"}
eval $cmd

As you see, I changed the output to:

export NAME=VALUE

format. It would be great if we could get such output as well.

[igr]

@mikansoro figured out the core issue: weep uses SHELL env variable to figure out the shell (os.Getenv("SHELL")).

This is not the correct way of doing so. The SHELL variable indicates the default shell, not necessarily one that is used; like one specified in Shebang line of the script.

Solution: don't rely on the SHELL env. I tried quickly to find a go library that resolves shell correctly, but no luck. What works for me is the following shell command:

sh -c 'ps -p $$ -o ppid=' | xargs ps -o comm= -p

This should give the proper shell binary name, like /opt/homebrew/Cellar/fish/3.5.1/bin/fish