Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hint to error responses on fetch API #774

Open
skandragon opened this issue Feb 5, 2018 · 1 comment
Open

Add a hint to error responses on fetch API #774

skandragon opened this issue Feb 5, 2018 · 1 comment

Comments

@skandragon
Copy link
Contributor

Currently, a response like

data: {"type":"error","message":"IllegalStateException: unknown word ':eqx'"}

is generated for many reasons, some of which retries would work, some they would not.

It would be useful to add an indicator showing if a retry could be successful, so we can easily determine if we need to bounce failure to the user of Kayenta, or if we should internally retry. We could default to retrying, so only hard errors on the query syntax itself need to be decorated initially.

In all forms of error cases, a 200 response is given, so we cannot use that today. That would be another option, but the JSON format is easier to handle in our current code.

@brharrington brharrington added this to the 1.6.0 milestone Feb 5, 2018
@pparth
Copy link

pparth commented Feb 6, 2018

+1.
This is very important to us too. We use a custom Atlas Query Editor and it would be great to have this feature.

@brharrington brharrington modified the milestones: 1.6.0, 1.7.0 Nov 27, 2018
@brharrington brharrington modified the milestones: 1.7.0, 1.8.0 Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants