Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single option to turn on Spotlight #1618

Open
rdmark opened this issue Oct 12, 2024 · 3 comments
Open

Use a single option to turn on Spotlight #1618

rdmark opened this issue Oct 12, 2024 · 3 comments
Milestone

Comments

@rdmark
Copy link
Member

rdmark commented Oct 12, 2024

Right now we have three afp.conf options that all need to be turned on to enable Spotlight.

  • spotlight
  • start tracker
  • start dbus

The two latter were added in https://sourceforge.net/p/netatalk/feature-requests/91/ with little context. I can't immediately think of a reason why you'd ever enable spotlight with also wanting to have tracker and dbus running. Maybe there was some corner case bug or instability early on when spotlight functionality was fresh?

Anyhow, I think these three should be compressed into a single option.

@rdmark rdmark added this to the release-4.1 milestone Oct 12, 2024
@singular0
Copy link
Contributor

I think this split has something to do with #54 (i.e. if you run indexer as a separate service on system dbus, it starts to make sense).

@rdmark
Copy link
Member Author

rdmark commented Oct 14, 2024

That's a good point. So there may be a case for controlling the indexer dbus separately.

Can you see a reason for keeping spotlight and tracker (indexer) as separate options? The only reason I can think of would be if we in the future introduced support for multiple indexing backends, and controlled the active backend dynamically rather than at compile time. E.g. #1409

But at that point the option shouldn't be called start tracker but rather something like indexer backend.

@singular0
Copy link
Contributor

No, at the moment I don't see any scenario in which we may want to enable spotlight without controlling indexer process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants