Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate speed-dependent coil load ratio input parameters into a single parameter. #10369

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from
Open

Consolidate speed-dependent coil load ratio input parameters into a single parameter. #10369

wants to merge 36 commits into from

Commits on Jan 9, 2024

  1. Ported function signature changes.

    @tanaya-mankad
    tanaya-mankad committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    e404a0d View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Fix clang-format.

    @tanaya-mankad
    tanaya-mankad committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    64088c6 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Remove extra function parameter in tests.

    @tanaya-mankad
    tanaya-mankad committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    ad6d7b6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of https://github.com/NREL/EnergyPlus into mer… 

    …ge-coil-load-ratios
    @tanaya-mankad
    tanaya-mankad committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    6d3cc5c View commit details
    Browse the repository at this point in the history

  3. Revert CoilPLR to m_CoolingSpeedRatio.

    @tanaya-mankad
    tanaya-mankad committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    45ddc48 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Pass locally-calculated CoilPLR to CoilDX simulate inside calcUnitary… 

    …CoolingSystem.
    @tanaya-mankad
    tanaya-mankad committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    e2fade2 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Modify input CoilPLR calculation prior to DXCoil simulate() call.

    @tanaya-mankad
    tanaya-mankad committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4b62938 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of https://github.com/NREL/EnergyPlus into mer… 

    …ge-coil-load-ratios
    @tanaya-mankad
    tanaya-mankad committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    9f8815b View commit details
    Browse the repository at this point in the history

  3. Correct parameters in call to DXCoil simulate.

    @tanaya-mankad
    tanaya-mankad committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4716bfb View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Merge branch 'develop' of https://github.com/NREL/EnergyPlus into mer… 

    …ge-coil-load-ratios
    @tanaya-mankad
    tanaya-mankad committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    cf346b1 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Fix PartLoadRatioReport, initialize cooling speed to 1, assert if 0.

    @tanaya-mankad
    tanaya-mankad committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    b992bd8 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Merge branch 'develop' of https://github.com/NREL/EnergyPlus into mer… 

    …ge-coil-load-ratios
    @tanaya-mankad
    tanaya-mankad committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    374707a View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Update test IDF.

    @tanaya-mankad
    tanaya-mankad committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    7ab582b View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. Merge from NREL develop.

    @tanaya-mankad
    tanaya-mankad committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    cb92a78 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge from remote.

    @tanaya-mankad
    tanaya-mankad committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    d4ac8d1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'merge-coil-load-ratios' of https://github.com/bigladder… 

    …/EnergyPlus into merge-coil-load-ratios
    @tanaya-mankad
    tanaya-mankad committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    b05f869 View commit details
    Browse the repository at this point in the history

  3. Merge from nonzero-speed branch.

    @tanaya-mankad
    tanaya-mankad committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    a087d67 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Fix formatting.

    @tanaya-mankad
    tanaya-mankad committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    4a83d3d View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'develop' of https://github.com/NREL/EnergyPlus into mer… 

    …ge-coil-load-ratios
    @tanaya-mankad
    tanaya-mankad committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    30bf1ab View commit details
    Browse the repository at this point in the history

  2. Small corrections after develop merge.

    @tanaya-mankad
    tanaya-mankad committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f7e0e51 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Merge branch 'nonzero-cooling-speed-num' of https://github.com/NREL/E… 

    …nergyPlus into merge-coil-load-ratios
    @tanaya-mankad
    tanaya-mankad committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    8590971 View commit details
    Browse the repository at this point in the history

  2. Allow coil speed == 0.

    @tanaya-mankad
    tanaya-mankad committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    37ddbeb View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Remove zero-speed unit test.

    @tanaya-mankad
    tanaya-mankad committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    12eedcf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of https://github.com/NREL/EnergyPlus into mer… 

    …ge-coil-load-ratios
    @tanaya-mankad
    tanaya-mankad committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    02faaef View commit details
    Browse the repository at this point in the history

  3. Remove line from accidental merge.

    @tanaya-mankad
    tanaya-mankad committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c63253d View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Simplify PLR assignment.

    @tanaya-mankad
    tanaya-mankad committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    641d623 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Merge branch 'develop' into merge-coil-load-ratios

    @tanaya-mankad
    tanaya-mankad committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    3042fae View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge from nonzero-cooling-speed-num.

    @tanaya-mankad
    tanaya-mankad committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f118192 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of https://github.com/NREL/EnergyPlus into mer… 

    …ge-coil-load-ratios
    @tanaya-mankad
    tanaya-mankad committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5505f01 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'merge-coil-load-ratios' of https://github.com/bigladder… 

    …/EnergyPlus into merge-coil-load-ratios
    @tanaya-mankad
    tanaya-mankad committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    cb8806f View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Merge branch 'develop' of https://github.com/NREL/EnergyPlus into mer… 

    …ge-coil-load-ratios
    @tanaya-mankad
    tanaya-mankad committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    deab5a2 View commit details
    Browse the repository at this point in the history

  2. Fix clang-format.

    @tanaya-mankad
    tanaya-mankad committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    45b87e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Reassess how singlemode interprets PLR.

    @tanaya-mankad
    tanaya-mankad committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    59b222f View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge branch 'develop' of https://github.com/NREL/EnergyPlus into mer… 

    …ge-coil-load-ratios
    @tanaya-mankad
    tanaya-mankad committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d7db59e View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Fix setpoint-based plr.

    @tanaya-mankad
    tanaya-mankad committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    e3d4abe View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Allow speed=0 if compressor is off.

    @tanaya-mankad
    tanaya-mankad committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    be230f3 View commit details
    Browse the repository at this point in the history