Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mycroft config on dev install #106

Open
krisgesling opened this issue Nov 5, 2021 · 1 comment
Open

Mycroft config on dev install #106

krisgesling opened this issue Nov 5, 2021 · 1 comment
Labels
question Further information is requested

Comments

@krisgesling
Copy link
Contributor

I just noticed that we're setting the enclosure.platform config to mycroft_mark_2 on install.

Is that to get around people using if platform == "mycroft_mark_2" in Skills etc, when they want to check if a GUI is connected? Or are there other reasons a dev environment should pretend to be a Mark 2?

I can certainly see having a "Mark II" mode being useful - to try and emulate a Mark II setup as much as possible - config, correct dimensions, etc. But I'm wondering if that should be an intentional option rather than the default config?

It jumped out at me because if we are writing to a mycroft.conf file we'll need to switch to the XDG path for it instead of the hard coded value.

Any thoughts or preferences?

@krisgesling krisgesling added the question Further information is requested label Nov 5, 2021
@AIIX
Copy link
Collaborator

AIIX commented Nov 29, 2021

Will add the configuration for platform to the dev_script.sh, the hardcoded path is in /etc/mycroft its at system level, so if mycroft-core does adopt xdg even at system level config, we can then switch to /etc/xdg/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants