-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look into stabler methods of integration testing #23
Comments
I'm a complete docker newbie, so I'm not quite sure how to approach that yet. @mafintosh what did you do in all your fuse work to avoid these locked up file system states? |
@Munter i usually try to have my fuse stuff be very minimal so there will be fewer crashes and then maybe run that as a daemon that something more advanced interface with. Running it inside docker is non-trivial since it requires privileged access to mount drives. In my fuse-bindings tests i always unmount + mount in the tests on every testcase to work around this problem as well. Fx, https://github.com/mafintosh/fuse-bindings/blob/master/test/write.js (adding the force option makes it unmount first) |
Wow, I really thought to myself "oh, the point of fuse is that it can be run in user space with user priveleges, so it'll be cool in a Docker container even without using a root user within the container". But now you said that, a quick search says you have to get involved with altering picky configs to make this work. Never mind, that's probably more trouble than it's worth :\ |
But +1 for mounting before and unmounting after every test, I think this is a necessary step. |
I'm already mounting and unmounting per file in |
The test I submitted for the other bug in PR #24 (I think) does nearly that
On Wed, 30 Sep 2015 09:09 Peter Müller [email protected] wrote:
|
More of a suggestion ticket really - one idea I had that might help to get around all the messiness of still-mounted FSs after failed cases etc etc is to run within Docker containers. A simple image which pretty much just has fuse installed would serve the purpose and would allow the test framework to trash and rebuild a clean state much more reliably.
The text was updated successfully, but these errors were encountered: