Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unit tests #22

Open
Munter opened this issue Sep 29, 2015 · 1 comment
Open

Implement unit tests #22

Munter opened this issue Sep 29, 2015 · 1 comment

Comments

@Munter
Copy link
Owner

Munter commented Sep 29, 2015

The current test setup is more of an integration test than an actual unit test. This means testing is vulnerable to all sorts of race conditions, side effects from file indexing when mounting a drive etc.

It would be highly beneficial to split out some of the actual computation from the mounted file system part of the code to better guarantee stability in those parts.

Hopefully this will also make the integration testing part easier, as fewer moving parts will have to be tested on a brittle setup

@jackfranklin
Copy link

Definitely up for taking a stab at this 👍 Will hopefully find some time soon to read through the code before thinking about how to split it up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants