-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser requests to files in mounted filesystem not completing #178
Comments
My proposed solution to this: |
I think we're going to switch it back to compile on stat. With an on-disk cache so it can persist across instances. But this time around I need to be sure I can write tests that actually cover more things. I'll meet with @papandreou to talk that through |
If you need any help or don't have time to complete this, ping me. I guess I am more in need of this issue being resolved than yourself :) |
We just had a bit of a code sprint and wrote a file system backed cache with much of the same basic plumbing than fusile, just better thought through. With a file system backed cache I should be able to rewrite fusile to compile on stat without to much of a start up penalty. That should fix the problem of wrongly reported file lengths. |
The problem: When using mounted directory as static file root with expressjs, browser requests to files doesn't seem to complete. Tested on Chrome.
An example is attached - test-fusile.zip. To run the exmaple, first do
npm install
, thennode_modules/fusile/bin/fusile-bin.js http-src/ http-dev/
. Then on a second terminal runnode server.js
.I believe the problem is caused by a wrong Content-Length HTTP header size, which in turn causes browser to wait forever. Expressjs sets Content-Length to size of file, and fusile seems to return the wrong file size due to this line -> https://github.com/Munter/fusile/blob/master/lib/index.js#L176.
The text was updated successfully, but these errors were encountered: