Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The jupyter notebooks were not updated when name changes occurred. #95

Open
bannanc opened this issue Mar 12, 2020 · 2 comments
Open

The jupyter notebooks were not updated when name changes occurred. #95

bannanc opened this issue Mar 12, 2020 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@bannanc
Copy link
Member

bannanc commented Mar 12, 2020

Multiple jupyter notebooks are having import errors related to name changes in the most recent pull request. That means the tests are not running the notebooks any more. @j-wags
@bannanc bannanc added the help wanted Extra attention is needed label Mar 12, 2020
@bannanc
Copy link
Member Author

bannanc commented Mar 12, 2020

This would be an easy thing to fix and potentially a good way for someone to get to know the code base. The code snippets in the preprint were run with this release.

@bannanc
Copy link
Member Author

bannanc commented Mar 12, 2020

It looks like the read the docs examples not from notebooks are also wrong. I put a lot of work into those being tested too at some point so I’m not sure why they aren’t being tested now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bannanc