Skip to content
This repository has been archived by the owner on Sep 15, 2024. It is now read-only.

Shield opacity breaking on patterned shields #12

Open
Name-Searcher opened this issue Sep 4, 2023 · 2 comments
Open

Shield opacity breaking on patterned shields #12

Name-Searcher opened this issue Sep 4, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Name-Searcher
Copy link

When I put a pattern on my shield the opacity turns back to 100% no matter where I put the slider

@MicrocontrollersDev
Copy link
Owner

can confirm. won’t have time to work on this for the next couple weeks so it’ll be a while before this is fixed

@MicrocontrollersDev MicrocontrollersDev added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Sep 5, 2023
@MicrocontrollersDev
Copy link
Owner

finally got a chance to look into this and i simply don’t know how to fix this. i’ll keep trying to find a way but unless someone else prs a fix it might not happen.

issue is when the shield is patterned it calls to a render function in the banner block entity class which then again calls to another render function elsewhere. only the last render call supplies opacity, and simply changing that would affect all block entities

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants