Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Known token being displayed as unknown on the redesigned erc20 transfer #27970

Open
bschorchit opened this issue Oct 18, 2024 · 0 comments
Labels
regression-develop Regression bug that was found on development branch, but not yet present in production Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug

Comments

@bschorchit
Copy link

Describe the bug

If a user doesn't have a token added to their wallet, we display unknown even if it's a known token (e.g. USDC on Ethereum).

Expected behavior

No response

Screenshots/Recordings

Before adding USDC to the wallet:
Screenshot 2024-10-18 at 17 51 33

After adding USDC to the wallet:
Screenshot 2024-10-18 at 17 54 33

Steps to reproduce

  1. Fresh install from this build feat: dapp initiated token transfer #27875 (comment)
  2. Go to test dapp
  3. Click on malicius erc20 transfer while on Ethereum
  4. See Unknown on the top of the confirmation
  5. Reject the transaction
  6. Import the usdc token to the wallet
  7. Repeat steps 3 & 4
  8. See USDC on the top of the confirmation instead of Unknown

Error messages or log output

No response

Detection stage

On the development branch

Version

12.8

Build type

None

Browser

Brave

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@bschorchit bschorchit added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team labels Oct 18, 2024
@metamaskbot metamaskbot added the regression-develop Regression bug that was found on development branch, but not yet present in production label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-develop Regression bug that was found on development branch, but not yet present in production Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

2 participants