Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ppom failing on RC v12.5 - Ethereum Mainnet #27951

Open
Unik0rnMaggie opened this issue Oct 18, 2024 · 3 comments
Open

[Bug]: ppom failing on RC v12.5 - Ethereum Mainnet #27951

Unik0rnMaggie opened this issue Oct 18, 2024 · 3 comments
Labels

Comments

@Unik0rnMaggie
Copy link
Contributor

Unik0rnMaggie commented Oct 18, 2024

Describe the bug

PPOM failing on Ethereum Mainnet

Expected behavior

PPOM alert should work as expected

Screenshots/Recordings

Ethereum.Mainnet.Chrome.mov

Steps to reproduce

  1. go to test Dapp
  2. Switch to Ethereum Mainnet in MetaMask
  3. Trigger any of the following:
Malicious ERC20 transfer (USDC)
Malicious ERC20 Approval (BUSD) 
Malicious Set Approval for All 
Malicious ERC 20 Approval with Odd Hex Data

  1. See error Error validating JSON RPC using PPOM: Error: simulation: fallback: (code: -32000, message: , data: None)
Ethereum.Mainnet.Firefox.mov

Error messages or log output

No response

Detection stage

During release testing

Version

12.5.0

Build type

Other (please specify exactly where you obtained this build in "Additional Context" section)

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@Unik0rnMaggie Unik0rnMaggie added type-bug team-confirmations Push issues to confirmations team regression-RC-12.5 Regression bug that was found in release candidate (RC) for release 12.5 labels Oct 18, 2024
@metamaskbot metamaskbot added regression-RC-12.5.0 and removed regression-RC-12.5 Regression bug that was found in release candidate (RC) for release 12.5 labels Oct 18, 2024
@Unik0rnMaggie
Copy link
Contributor Author

On Linea network there is no console error, but the malicious transactions are not flagged:

Malicious ERC20 transfer (USDC) - not flagged;
Malicious ERC20 Approval (BUSD) - not flagged;
Malicious Set Approval for All - not flagged
Malicious ERC 20 Approval with Odd Hex Data - not flagged

Linea.mov

@sleepytanya
Copy link
Contributor

@Unik0rnMaggie Linea may not be fully supported yet. I see the same behavior in prod and in RC 12.5.0:

Malicious ERC20 transfer (USDC) - not flagged;
Malicious ERC20 Approval (BUSD) - not flagged;
Malicious Set Approval for All - not flagged
Malicious ERC 20 Approval with Odd Hex Data - not flagged
Sign Permit -not flagged

@bschorchit

@sleepytanya
Copy link
Contributor

PPOM works for me in the latest build #27411 (comment)

Screen.Recording.2024-10-18.at.10.42.46.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

3 participants