Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some timings and output screenshots for debugging #66

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jontaylor
Copy link

@jontaylor jontaylor commented Nov 1, 2020

I've tweaked some of the timings, which seem to have improved reliability for me although its not very scientific.

The more interesting change is to output 4 sets of screenshots which help with debugging.

These can be automatically uploaded in case of failure as artificats into github with the following main.yml changes

  -   name: Upload artifact wait_for_interface_markdown.png
      if: ${{ failure() }}
      uses: actions/upload-artifact@v2
      with:
        name: wait_for_interface_markdown.png
        path: /tmp/wait_for_interface_markdown.png
        retention-days: 5
  -   name: Upload artifact wait_for_interface_json.png
      if: ${{ failure() }}
      uses: actions/upload-artifact@v2
      with:
        name: wait_for_interface_json.png
        path: /tmp/wait_for_interface_json.png
        retention-days: 5  
  -   name: Upload artifact signin_markdown.png
      if: ${{ failure() }}
      uses: actions/upload-artifact@v2
      with:
        name: signin_markdown.png
        path: /tmp/signin_markdown.png
        retention-days: 5
  -   name: Upload artifact signin_json.png
      if: ${{ failure() }}
      uses: actions/upload-artifact@v2
      with:
        name: signin_json.png
        path: /tmp/signin_json.png
        retention-days: 5        

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant