Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create drop-down for Resurvey Validation key-value pairs and include checkbox #2538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aarewhyan
Copy link
Contributor

@aarewhyan aarewhyan commented Mar 31, 2024

Fixes #1101. Continuation of pr #2251.

Uses a map on checkbox updates so as to not query the database on every checkbox click.

Two questions here -

  1. It doesn't seem to me to be a good-first issue as I had to deal with cursor deadlocks and memory leaks for updating the header checkbox (but that's beside the point). I was able to fix the former but the latter issue still persists. All I could circle out was, when invoking resetValidator() after the checkbox update to db, the getDefaultValidator(c).reset(c) method makes the app ANR (Reson- Changing to new focus Window timeout), some threading issue I guess, and if I run the program without the reset then, no problem while the app is open but when the app is closed and a new instance is opened, it crashes the app again for the same reason. Meaning there is a conflict with the updated values and the old values that were never rest. This only happens when resetValidator() is called for the checkbox update and not for any other calling of resetValidator() (like adding a ruleset or updating it).

  2. I would ask you to point me on how to invoke the following page directly, for testing the resurvey validators. All I could figure out was that as this page is part of the PerfEditorFragment, it can only be invoked when a preferenceScreen is created which itself is created by PerfEditor & PerfEditorActivity. What I can't figure out is how is this created. If you could point me to a simple initialization of this page that would be helpful.
    Validatorprefs

@aarewhyan
Copy link
Contributor Author

@simonpoole can you give some review on the above questions related to the pull request....?

@simonpoole
Copy link
Collaborator

@simonpoole can you give some review on the above questions related to the pull request....?

I'm away till the end of next week and will give it a look then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dropdowns with tag information for "re-survey" entries, add enable/disable
2 participants