Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect value for steps.jacoco.outputs.coverage-changed-files #71

Open
alexlambrides opened this issue Sep 21, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@alexlambrides
Copy link

The value outputted by the action for steps.jacoco.outputs.coverage-changed-files is different from the value mentioned in the comment.
Here is an example comment from my repository:

Code Coverage

Overall Project 30.23% -0.08%
Files changed 77.71% 🍏

And for the same action run, this was printed in the debug logs for coverage-changed-files:

##[debug]Set output coverage-changed-files = 34.72

In the jacoco-playground example repository, you can see the same issue for this pull request and action run:
thsaravana/jacoco-playground#24 (comment)
https://github.com/thsaravana/jacoco-playground/actions/runs/5707555753/job/15466273007?pr=24#step:8:11

Notice the comment states that the changed files percent is 38.24%, while the action prints out Changed Files coverage 35.25

@gokhan-oner
Copy link

gokhan-oner commented Sep 22, 2023

I hit the same issue & debugged a bit. It seems its introduced in 1.6. In 1.4, value in the report matches the steps.jacoco.outputs.coverage-changed-files but in newer versions, its incorrect. In some cases, it shows as passing in the report but check fail.

In my case, its more obvious: 1.4 & 1.5 reports 66.2%, 1.6+ reports 100%. So it seems steps.jacoco.outputs.coverage-changed-files is correct my value shown in the label is wrong!

@thsaravana thsaravana self-assigned this Oct 6, 2023
@thsaravana thsaravana added this to the 1.7 milestone Oct 6, 2023
@thsaravana thsaravana added the bug Something isn't working label Oct 6, 2023
@thsaravana thsaravana modified the milestones: 1.7, 1.7.1 Aug 30, 2024
@instrap instrap modified the milestones: 1.7.1, 1.7.2 Sep 8, 2024
@thsaravana thsaravana modified the milestones: 1.7.2, 1.7.4 Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants