Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mesh_tools.py #158

Merged
merged 2 commits into from
Sep 25, 2022
Merged

Update mesh_tools.py #158

merged 2 commits into from
Sep 25, 2022

Conversation

kujaku11
Copy link
Collaborator

@kujaku11 kujaku11 commented Nov 30, 2021

Added a function for rounding a number. This will eliminate 0's when the mesh elements are single digits as described in issue #157 .

Added a function called get_rounding that will round to the correct significant digits. Previously it was set to -2, which causes 0's when the mesh elements are 0.

Description

Added the get_rounding method to all the mesh creating functions to make sure the rounding is properly set.

Motivation and Context

fixes issue #157

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Added a function for rounding a number.  This will eliminate 0's when the mesh elements are single digits as described in issue #157 .
@kujaku11 kujaku11 requested a review from zhang01GA November 30, 2021 01:19
@kujaku11 kujaku11 merged commit 7f230ff into develop Sep 25, 2022
@kujaku11 kujaku11 deleted the patch-157 branch September 25, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant