New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standard amp-selector is being removed #263

Open

imansa opened this issue May 19, 2019 · 1 comment

imansa commented May 19, 2019

amp validator is removing amp-selector tag because it is not defined on Lullabot\AMP\Spec\ValidationRulesFactory class

this is link to tag documents
link to amp-select tag on amp.dev

Author

imansa commented May 19, 2019

a sample from warnings

<amp-selector id="carouselSelector" on="select:carousel.goToSlide(index=event.targetOption)" layout="container"> on line 2
 - The tag 'amp-selector' is disallowed.
 [code: DISALLOWED_TAG  category: DISALLOWED_HTML]
 ACTION TAKEN: amp-selector tag was removed due to validation issues.

imansa mentioned this issue

force to use amp-img option attribute in amp-carousel ampproject/amphtml#22378

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment