Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove proc-macro2 from default features #12

Open
LukasKalbertodt opened this issue Mar 5, 2023 · 0 comments
Open

Remove proc-macro2 from default features #12

LukasKalbertodt opened this issue Mar 5, 2023 · 0 comments

Comments

@LukasKalbertodt
Copy link
Owner

Default features in library crates that are not used by the vast majority of downstream crates, should likely not be default features. A quick GitHub search shows: there are 46 total repositories with litrs in Cargo.toml and 35 of those also have proc-macro2 in Cargo.toml. And 5 repositories set default-features = false for litrs. This shows what is well known: people forget to disable default features they don't need. That leads to more dependencies that are compiled for no reason. Though 35 of 46 sounds like most people use the proc-macro2 feature. Well, I have looked through a few of those repos and several do use proc-macro2 in general, but not for litrs.

So I'm inclined to make proc-macro2 a non-default feature of litrs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant