You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Default features in library crates that are not used by the vast majority of downstream crates, should likely not be default features. A quick GitHub search shows: there are 46 total repositories with litrs in Cargo.toml and 35 of those also have proc-macro2 in Cargo.toml. And 5 repositories set default-features = false for litrs. This shows what is well known: people forget to disable default features they don't need. That leads to more dependencies that are compiled for no reason. Though 35 of 46 sounds like most people use the proc-macro2 feature. Well, I have looked through a few of those repos and several do use proc-macro2 in general, but not for litrs.
So I'm inclined to make proc-macro2 a non-default feature of litrs.
The text was updated successfully, but these errors were encountered:
Default features in library crates that are not used by the vast majority of downstream crates, should likely not be default features. A quick GitHub search shows: there are 46 total repositories with
litrs
inCargo.toml
and 35 of those also haveproc-macro2
inCargo.toml
. And 5 repositories setdefault-features = false
for litrs. This shows what is well known: people forget to disable default features they don't need. That leads to more dependencies that are compiled for no reason. Though 35 of 46 sounds like most people use theproc-macro2
feature. Well, I have looked through a few of those repos and several do useproc-macro2
in general, but not forlitrs
.So I'm inclined to make
proc-macro2
a non-default feature oflitrs
.The text was updated successfully, but these errors were encountered: