[Not urgent!] LF-4384(b): Refactor useAnimalOrBatchRemoval #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SayakaOno
requested review from
antsgar,
kathyavini and
Duncan-Brain
and removed request for
a team and
kathyavini
16 tasks
…d SingleAnimalView
SayakaOno
force-pushed
the
LF-4384_2/Refactor_useAnimalOrBatchRemoval
branch
from
984e09a
to
5290430
Compare
SayakaOno
changed the title
Base automatically changed from
LF-4384/End-to-End_Animal_Details
to
integration
November 28, 2024 16:21
| setSelectedInventoryIds((selectedInventoryIds) => { | ||
| return selectedInventoryIds.filter((i) => { | ||
| const { kind, id } = parseInventoryId(i); | ||
| return kind === animalOrBatchKey && ids.includes(id); |
There was a problem hiding this comment.
The previous filter was : !selectedAnimalIds.includes(i))
Everything looks like it works so I am not sure it matters, but it looks like it is setting the selected inventory id to the ones that were successfully removed?
There was a problem hiding this comment.
Thank you so much for catching it! I remember getting confused about how to use .filter() suddenly and ended up flipping the condition! 🙏
It's fixed now!
Duncan-Brain
previously approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the
useAnimalOrBatchRemovalhook accepts inventory IDs and parses them. This parsing is redundant for theSingleAnimalView, which already has a parsed ID. This PR makes the hook more generic by:useAnimalOrBatchRemovalto accept:ids withkind(animal or batch key) instead of inventory IDsonSuccessinstead ofsetSelectedInventoryIdssetSelectedInventoryIdslogic to theInventorycomponent.(This PR addresses the comment on #3534)