Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support primary_key in mirror tag #367

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Support primary_key in mirror tag #367

wants to merge 9 commits into from

Conversation

kempfsn
Copy link

@kempfsn kempfsn commented Mar 18, 2023

This adds support for a public key of the primary mirror. The primary key is used in the following places:

  • to verify the Release of the primary mirror for the initvm
  • to add the primary key to the keyring of the initvm
  • to call debootstrap with the primary key when building the rootfs
  • to call debootstrap with the primary key when creating a pbuilder

Resolves #104 and #365.

Stefan Kempf added 9 commits March 18, 2023 11:54
Add primary key to schema
4f431d2 
Signed-off-by: Stefan Kempf <[email protected]>
Add key for host mirror
82920a3 
Signed-off-by: Stefan Kempf <[email protected]>
Make add_key return path of added key
832c26c 
Signed-off-by: Stefan Kempf <[email protected]>
Add function to return primary key if there is one
f73f64a 
Signed-off-by: Stefan Kempf <[email protected]>
Make debootstrap use key for primary mirror if there is one
d9c9fee 
Signed-off-by: Stefan Kempf <[email protected]>
Add keyring to debootstrapopts when creating a pbuilder
4e25d65 
Signed-off-by: Stefan Kempf <[email protected]>
Import primary_key for elbe check_updates command
987ff92 
Signed-off-by: Stefan Kempf <[email protected]>
Add primary key to trusted keys for fetching initvm installer files
7375f8c 
Signed-off-by: Stefan Kempf <[email protected]>
Add primary key to initvm keyring
470a605 
Signed-off-by: Stefan Kempf <[email protected]>
@d4nuu8
Copy link
Contributor

d4nuu8 commented May 10, 2023

We are having exactly the same problem. I'm going to test this patch with our code base and give you feedback.

@bgermann Could you take a look at this, too?

@d4nuu8
Copy link
Contributor

d4nuu8 commented May 23, 2023

Doesn't work for me unfortunately. But I'm not sure if it is our special corporate environment or the patch. APT is failing to install packages because of verification errors (e.g. busybox).

I'm missing the time to dig deeper here right now. Sorry.

@bgermann bgermann mentioned this pull request May 26, 2023
Closed
@t-8ch
Copy link
Contributor

t-8ch commented Nov 18, 2024

Sorry for the long delay.
I used this PR, rebased it and cleaned up a few minor parts.

https://lists.linutronix.de/pipermail/elbe-devel/2024-November/007571.html

Could you give it a test?
@kempfsn I kept your authorship. Could you confirm if you are fine with it?

@kempfsn
Copy link
Author

kempfsn commented Nov 23, 2024 •
edited
Loading

Sorry for the long delay. I used this PR, rebased it and cleaned up a few minor parts.

https://lists.linutronix.de/pipermail/elbe-devel/2024-November/007571.html

Could you give it a test? @kempfsn I kept your authorship. Could you confirm if you are fine with it?

@t-8ch Thanks for picking it up. I do not have this use case anymore and cannot test unfortunately. But would be fine with it.

t-8ch added a commit that referenced this pull request Nov 26, 2024
@t-8ch
Support primary_key in mirror tag
803c80d 
Rebased variant of #367

To: [email protected]
Cc: Stefan Kempf <[email protected]>
Signed-off-by: Thomas Weißschuh <[email protected]>

---
Changes in v2:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v1: https://lore.kernel.org/r/[email protected]



--- b4-submit-tracking ---
# This section is used internally by b4 prep for tracking purposes.
{
  "series": {
    "revision": 2,
    "change-id": "20241118-primary_key-e71b055eddf8",
    "prefixes": [],
    "history": {
      "v1": [
        "[email protected]"
      ]
    }
  }
}
@t-8ch
Copy link
Contributor

t-8ch commented Nov 29, 2024

@kempfsn Thanks for the permission!
I'll wait to see if somebody else has the time to test it for their usecase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add primary_key node to the mirror tag
3 participants
@kempfsn @d4nuu8 @t-8ch