Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AST Parser Observation #84

Open
jeswr opened this issue Jan 30, 2022 · 1 comment
Open

AST Parser Observation #84

jeswr opened this issue Jan 30, 2022 · 1 comment

Comments

@jeswr
Copy link

jeswr commented Jan 30, 2022

I was just having a look at this codebase to get an understanding of how it worked (amazing work as usual btw.)

I noticed that the package you are using to parse and traverse the AST seems to be a little laborious on the user side - I use the package ts-morph a lot of the time when I am doing typescript parsing and codegen, and it already implements a lot of navigation functionality you currently need to do yourself (e.g. it as has .getClasses method to get all the classes in a file).

@rubensworks
Copy link
Member

I'm definitely open to an exploration into alternative AST traversal methods.
The code is written is such a way that it should be relatively easy to use different libs for that.

However, there are some particularities in our custom AST handling logic, so it might not be that easy to use a different lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants