Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add learning rate scheduling support for DeepSpeedStrategy #20320

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

amorehead
Copy link
Contributor

@amorehead amorehead commented Oct 5, 2024

What does this PR do?

  • Adds learning rate scheduling support for DeepSpeedStrategy
  • Credit to lvhoaa for suggesting this change to make Fabric's support for internal DeepSpeed features even more robust
Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs) N
  • x ] Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20320.org.readthedocs.build/en/20320/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Oct 5, 2024
@lantiga
Copy link
Collaborator

lantiga commented Oct 7, 2024

Thanks for the contribution @amorehead! Let's get to a green CI and take it from there

@lantiga
Copy link
Collaborator

lantiga commented Nov 12, 2024

hey @amorehead looks like CI failures are legit, let me know if you can fix those

@lantiga lantiga added the waiting on author Waiting on user action, correction, or update label Nov 12, 2024
@mergify mergify bot removed the has conflicts label Nov 25, 2024
src/lightning/fabric/strategies/deepspeed.py Outdated Show resolved Hide resolved
src/lightning/fabric/strategies/fsdp.py Outdated Show resolved Hide resolved
src/lightning/fabric/strategies/strategy.py Outdated Show resolved Hide resolved
src/lightning/fabric/strategies/xla_fsdp.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric strategy: deepspeed waiting on author Waiting on user action, correction, or update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants