-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add str method to datamodule #20301
Open
MrWhatZitToYaa
wants to merge
12
commits into
Lightning-AI:master
Choose a base branch
from
MrWhatZitToYaa:feature/9947_dataloader-string
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+163
−2
Open
Add str method to datamodule #20301
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a011366
Add feature implementation to datamodule for str method
MrWhatZitToYaa 137e7b5
Removed list / tuple case for datamodule str method
MrWhatZitToYaa efe0c3c
Added test cases for DataModule string function
MrWhatZitToYaa 23326d7
Reverted accidental changes in DataModule
MrWhatZitToYaa 122cf6d
Updated dataloader str method
MrWhatZitToYaa 9acf680
Merge branch 'master' into feature/9947_dataloader-string
lantiga 51a4901
Improvements to implementation of str method for datamodule
MrWhatZitToYaa d37dfb0
Merge branch 'master' into feature/9947_dataloader-string
lantiga 1ce0f92
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 20a2a0c
Implementing str method for datamodule
MrWhatZitToYaa e03aefb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6d05cfe
Add string method to datamodule
MrWhatZitToYaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with this is that there are no guarantees that any datasets actually exist as attributes.
I think a better design would be to leverage the contract, and get dataloaders through
self.train_dataloader
(caveat: it may be a dataloader or an iterable of dataloaders),self.val_dataloader
, etc, access theirdataset
property (https://pytorch.org/docs/stable/data.html#torch.utils.data.DataLoader) and produce a string from there in a similar way to the current way.Also instead of ignoring non-Dataset subclasses in this case, we could call str from whatever is returned as dataset.
I think it's a valuable addition, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good idea. I also had a similar idea in the beginning but discarded it because I thought it would add too much overhead. But I did some research an DataLoader should not add too much overhead to the actual dataset so we can use it in the str method.
Your suggestion would make the method more save, while still maintaining the same functionality, since one has to call prepare and setup anyway before one is able to access the dataset information.
I will try to implement your suggestion