Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TransformerEngine and Activation checkpointing interaction for thunderFX #1473

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix TransformerEngine and Activation checkpointing interaction for thunderFX #1473

wants to merge 2 commits into from

Conversation

kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Nov 26, 2024 •
edited
Loading

Fixes #1424

Also fixes #1050

TODO - Add test and do sanity check whether running backward under fp8_autocast enabled is ok?

@tfogal
Copy link
Collaborator

tfogal commented Nov 27, 2024

This was effected by the PrimIDs.ITEM issue (see #1471) and so i'm merging main to help get a better CI signal.
(this may mean you need to force-push the branch if you had uncommitted changes, Kshiteej).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry Awaiting requested review from mruberry mruberry will be requested when the pull request is marked ready for review mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga will be requested when the pull request is marked ready for review lantiga is a code owner

@t-vi t-vi Awaiting requested review from t-vi t-vi will be requested when the pull request is marked ready for review t-vi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kshitij12345 @tfogal