Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert batch size to strictly test OpenAIEmbeddingSpec for dynamic batching #370

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Nov 27, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

Improved test = reliability

This PR adds an assert to the batched input in the LitAPI to strictly confirm it's always batched when enabled.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (771a1c9) to head (a9a60bf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #370   +/-   ##
===================================
  Coverage    94%    94%           
===================================
  Files        25     25           
  Lines      1563   1563           
===================================
  Hits       1465   1465           
  Misses       98     98           

@aniketmaurya aniketmaurya merged commit 4a1a7b2 into main Nov 27, 2024
21 checks passed
@aniketmaurya aniketmaurya deleted the aniket/fix-batching-test branch November 27, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants