Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated TODO #396

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Remove outdated TODO #396

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4044e3
remove old TODO
TomasArrachea Nov 15, 2024
8fc92af
Merge branch 'dev' into remove_comment
TomasArrachea Nov 15, 2024
2433afd
Merge branch 'dev' into remove_comment
pablodeymo Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions services/bls_aggregation/blsagg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,11 +605,6 @@ func (a *BlsAggregatorService) closeTaskGoroutine(taskIndex types.TaskIndex) {

// verifySignature verifies that a signature is valid against the operator pubkey stored in the
// operatorsAvsStateDict for that particular task
// TODO(samlaf): right now we are only checking that the *digest* is signed correctly!!
// we could be sent a signature of any kind of garbage and we would happily aggregate it
// this forces the avs code to verify that the digest is indeed the digest of a valid taskResponse
// we could take taskResponse as an interface{} and have avs code pass us a taskResponseHashFunction
// that we could use to hash and verify the taskResponse itself
func (a *BlsAggregatorService) verifySignature(
taskIndex types.TaskIndex,
signedTaskResponseDigest types.SignedTaskResponseDigest,
Expand Down